Skip to content

Fix: Cursor pointer on clickable row for latest iTwinUI - #179

Merged
arome merged 2 commits into
mainfrom
omar/fix-cursor-row-clickable
Oct 9, 2025
Merged

Fix: Cursor pointer on clickable row for latest iTwinUI#179
arome merged 2 commits into
mainfrom
omar/fix-cursor-row-clickable

Conversation

@arome

@arome arome commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

iTwinUI changed their wrapper for the body of a table.
This changes better targets the rows of the table through the bodyProps instead of relying on some div attributes.

@arome
arome requested a review from aruniverse as a code owner October 9, 2025 13:29
@arome
arome merged commit 37aa13e into main Oct 9, 2025
5 checks passed
@arome
arome deleted the omar/fix-cursor-row-clickable branch October 9, 2025 13:30
@aruniverse
aruniverse requested a review from Copilot October 9, 2025 13:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes cursor pointer display on clickable table rows to accommodate changes in iTwinUI library structure. The change relocates the cursor styling from the main Table component to the bodyProps and updates CSS selectors to match the new DOM structure.

  • Moved cursor styling from Table className to bodyProps for better targeting
  • Updated CSS selectors to directly target rows instead of nested rowgroup/row structure
  • Applied consistent changes across both IModelGrid and ITwinGrid components

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
IModelGrid.tsx Moved cursor styling from Table className to bodyProps
IModelGrid.module.scss Updated CSS selector to directly target rows
ITwinGrid.tsx Moved cursor styling from Table className to bodyProps
ITwinGrid.scss Updated CSS selector to directly target rows
omar-fix-cursor-row-clickable_2025-10-09-13-29.json Added changelog entry for the fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants